Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: snapshot/system_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/process_snapshot.h ('k') | snapshot/test/test_module_snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/system_snapshot.h
diff --git a/snapshot/system_snapshot.h b/snapshot/system_snapshot.h
index 393bd271e872e62048f16d69be24dd0ef932fbc0..6dfede6870f7b62b47b6fb0db468372dd2bc30c1 100644
--- a/snapshot/system_snapshot.h
+++ b/snapshot/system_snapshot.h
@@ -29,6 +29,8 @@ namespace crashpad {
//! other characteristics.
class SystemSnapshot {
public:
+ virtual ~SystemSnapshot() {}
+
//! \brief A system’s operating system family.
enum OperatingSystem {
//! \brief The snapshot system’s operating system is unknown.
@@ -255,9 +257,6 @@ class SystemSnapshot {
int* daylight_offset_seconds,
std::string* standard_name,
std::string* daylight_name) const = 0;
-
- protected:
- ~SystemSnapshot() {}
};
} // namespace crashpad
« no previous file with comments | « snapshot/process_snapshot.h ('k') | snapshot/test/test_module_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698