Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 667923002: Standardize usage of virtual/override/final in ui/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
dcheng, aboxhall+watch_chromium.org, ben+views_chromium.org, ben+aura_chromium.org, cc-bugs_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-ipc_chromium.org, nona+watch_chromium.org, ozone-reviews_chromium.org, penghuang+watch_chromium.org, peter+watch_chromium.org, piman+watch_chromium.org, plundblad+watch_chromium.org, rsesek+watch_chromium.org, sadrul, sievers+watch_chromium.org, James Su, tdanderson+views_chromium.org, tdresser+watch_chromium.org, tfarina, Ian Vollick, yukishiino+watch_chromium.org, yusukes+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in ui/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=sky@chromium.org Committed: https://crrev.com/08038795458017a039565cfa158f0c379f91a007 Cr-Commit-Position: refs/heads/master@{#300446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1529 lines, -1743 lines) Patch
M ui/accessibility/ax_serializable_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_serializable_tree.cc View 1 chunk +11 lines, -24 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/app_list/app_list_folder_item.h View 3 chunks +15 lines, -15 lines 0 comments Download
M ui/app_list/app_list_folder_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/app_list_item_list_unittest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ui/app_list/app_list_menu.h View 1 chunk +6 lines, -7 lines 0 comments Download
M ui/app_list/app_list_model.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/app_list/app_list_model_unittest.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/cocoa/apps_grid_view_item.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/app_list/cocoa/apps_search_box_controller.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/cocoa/apps_search_results_model_bridge.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_model_bridge.mm View 2 chunks +7 lines, -9 lines 0 comments Download
M ui/app_list/pagination_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/app_list/pagination_model_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/app_list/search/dictionary_data_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/search/history.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/search/mixer_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ui/app_list/test/app_list_test_model.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.h View 2 chunks +30 lines, -31 lines 0 comments Download
M ui/app_list/test/run_all_unittests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/test/test_search_result.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/window.h View 3 chunks +11 lines, -12 lines 0 comments Download
M ui/base/accelerators/accelerator_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/accelerators/platform_accelerator_cocoa.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/cocoa/menu_controller_unittest.mm View 4 chunks +14 lines, -19 lines 0 comments Download
M ui/base/default_theme_provider.h View 1 chunk +14 lines, -15 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_mac.h View 1 chunk +22 lines, -23 lines 0 comments Download
M ui/base/ime/dummy_input_method.h View 1 chunk +25 lines, -26 lines 0 comments Download
M ui/base/ime/dummy_input_method_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.h View 1 chunk +30 lines, -30 lines 0 comments Download
M ui/base/ime/input_method_base.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ui/base/ime/input_method_base_unittest.cc View 3 chunks +25 lines, -51 lines 0 comments Download
M ui/base/ime/input_method_mac.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/base/ime/mock_input_method.h View 1 chunk +24 lines, -24 lines 0 comments Download
M ui/base/models/list_model_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/models/simple_combobox_model.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/models/simple_menu_model.h View 2 chunks +25 lines, -27 lines 0 comments Download
M ui/base/models/tree_node_model_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ui/base/resource/data_pack.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/test/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/closure_animation_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor.h View 2 chunks +22 lines, -24 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/compositor/float_animation_curve_adapter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/compositor/layer.h View 4 chunks +26 lines, -29 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 21 chunks +68 lines, -74 lines 0 comments Download
M ui/compositor/layer_animation_observer.h View 2 chunks +6 lines, -11 lines 0 comments Download
M ui/compositor/layer_animator_collection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/scoped_layer_animation_settings.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 chunk +13 lines, -16 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.h View 1 chunk +20 lines, -22 lines 0 comments Download
M ui/compositor/test/test_layer_animation_observer.h View 1 chunk +5 lines, -8 lines 0 comments Download
M ui/compositor/test/test_suite.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/compositor/transform_animation_curve_adapter.h View 2 chunks +21 lines, -21 lines 0 comments Download
M ui/events/device_data_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/event.h View 6 chunks +7 lines, -7 lines 0 comments Download
M ui/events/event_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event_target.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/gesture_listeners.h View 1 chunk +20 lines, -21 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 9 chunks +26 lines, -27 lines 0 comments Download
M ui/events/gesture_detection/motion_event_buffer.cc View 2 chunks +28 lines, -37 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.h View 1 chunk +20 lines, -20 lines 0 comments Download
M ui/events/gesture_detection/scale_gesture_listeners.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ui/events/gesture_detection/velocity_tracker.cc View 2 chunks +15 lines, -17 lines 0 comments Download
M ui/events/gestures/fling_curve.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl_mac.cc View 1 chunk +21 lines, -27 lines 0 comments Download
M ui/events/latency_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/test/events_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/test/mock_motion_event.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/test/platform_event_waiter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/test/test_event_handler.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/events/test/test_event_processor.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/events/test/test_event_target.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/animation/animation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/animation/animation_container_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/gfx/animation/animation_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/animation/linear_animation.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/animation/multi_animation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/animation/slide_animation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/animation/throb_animation.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ui/gfx/canvas_paint_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_analysis.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/color_analysis_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gfx/display_change_notifier_unittest.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M ui/gfx/geometry/r_tree_base.h View 3 chunks +13 lines, -13 lines 0 comments Download
M ui/gfx/image/canvas_image_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image.cc View 4 chunks +14 lines, -32 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 12 chunks +24 lines, -31 lines 0 comments Download
M ui/gfx/image/image_skia_unittest.cc View 5 chunks +9 lines, -15 lines 0 comments Download
M ui/gfx/interpolated_transform.h View 7 chunks +14 lines, -14 lines 0 comments Download
M ui/gfx/platform_font_mac.h View 1 chunk +12 lines, -12 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.h View 1 chunk +16 lines, -16 lines 0 comments Download
M ui/gfx/render_text_mac.h View 1 chunk +16 lines, -16 lines 0 comments Download
M ui/gfx/screen_mac.mm View 5 chunks +12 lines, -21 lines 0 comments Download
M ui/gfx/test/run_all_unittests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context_cgl.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ui/gl/gl_context_osmesa.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ui/gl/gl_context_stub.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ui/gl/gl_context_stub_with_extensions.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gl/gl_fence_arb.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gl/gl_fence_egl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gl/gl_fence_nv.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 5 chunks +10 lines, -10 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ui/gl/gl_image_memory.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ui/gl/gl_image_ref_counted_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_image_shared_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_image_stub.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface.h View 1 chunk +27 lines, -27 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 5 chunks +35 lines, -35 lines 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ui/gl/gl_surface_osmesa.h View 2 chunks +12 lines, -12 lines 0 comments Download
M ui/gl/gl_surface_stub.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_controller.h View 2 chunks +9 lines, -14 lines 0 comments Download
M ui/message_center/cocoa/notification_controller_unittest.mm View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/message_center/cocoa/popup_collection.mm View 1 chunk +5 lines, -9 lines 0 comments Download
M ui/message_center/cocoa/settings_controller.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/message_center/fake_message_center.h View 1 chunk +43 lines, -49 lines 0 comments Download
M ui/message_center/fake_message_center_tray_delegate.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/message_center/fake_notifier_settings_provider.h View 1 chunk +14 lines, -15 lines 0 comments Download
M ui/message_center/message_center_impl.h View 2 chunks +54 lines, -62 lines 0 comments Download
M ui/message_center/message_center_impl_unittest.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M ui/message_center/message_center_tray.h View 2 chunks +12 lines, -16 lines 0 comments Download
M ui/message_center/message_center_tray.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ui/message_center/message_center_tray_unittest.cc View 1 chunk +10 lines, -20 lines 0 comments Download
M ui/message_center/notification_delegate.h View 2 chunks +13 lines, -13 lines 0 comments Download
M ui/message_center/test/run_all_unittests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/native_theme/fallback_theme.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/native_theme/native_theme_base.h View 1 chunk +16 lines, -16 lines 0 comments Download
M ui/native_theme/native_theme_mac.h View 2 chunks +16 lines, -17 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 2 chunks +12 lines, -13 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/controls/webview/webview.h View 3 chunks +25 lines, -28 lines 0 comments Download
M ui/views/view.h View 4 chunks +18 lines, -19 lines 0 comments Download
M ui/views/view_targeter.h View 2 chunks +9 lines, -11 lines 0 comments Download
M ui/web_dialogs/test/test_web_contents_handler.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/web_dialogs/test/test_web_dialog_delegate.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ui/web_dialogs/web_dialog_ui.h View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/web_dialogs/web_dialog_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.h View 2 chunks +11 lines, -13 lines 0 comments Download
M ui/wm/core/cursor_manager.h View 1 chunk +22 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:32:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667923002/1
6 years, 2 months ago (2014-10-21 09:33:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 10:53:40 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 10:54:42 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/08038795458017a039565cfa158f0c379f91a007
Cr-Commit-Position: refs/heads/master@{#300446}

Powered by Google App Engine
This is Rietveld 408576698