Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: ui/web_dialogs/web_dialog_ui.h

Issue 667923002: Standardize usage of virtual/override/final in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/web_dialogs/test/test_web_dialog_delegate.h ('k') | ui/web_dialogs/web_dialog_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_WEB_DIALOGS_WEB_DIALOG_UI_H_ 5 #ifndef UI_WEB_DIALOGS_WEB_DIALOG_UI_H_
6 #define UI_WEB_DIALOGS_WEB_DIALOG_UI_H_ 6 #define UI_WEB_DIALOGS_WEB_DIALOG_UI_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 int width; 50 int width;
51 // Height of the dialog. 51 // Height of the dialog.
52 int height; 52 int height;
53 // The JSON input to pass to the dialog when showing it. 53 // The JSON input to pass to the dialog when showing it.
54 std::string json_input; 54 std::string json_input;
55 }; 55 };
56 56
57 // When created, the delegate should already be set as user data on the 57 // When created, the delegate should already be set as user data on the
58 // WebContents. 58 // WebContents.
59 explicit WebDialogUI(content::WebUI* web_ui); 59 explicit WebDialogUI(content::WebUI* web_ui);
60 virtual ~WebDialogUI(); 60 ~WebDialogUI() override;
61 61
62 // Close the dialog, passing the specified arguments to the close handler. 62 // Close the dialog, passing the specified arguments to the close handler.
63 void CloseDialog(const base::ListValue* args); 63 void CloseDialog(const base::ListValue* args);
64 64
65 // Sets the delegate on the WebContents. 65 // Sets the delegate on the WebContents.
66 static void SetDelegate(content::WebContents* web_contents, 66 static void SetDelegate(content::WebContents* web_contents,
67 WebDialogDelegate* delegate); 67 WebDialogDelegate* delegate);
68 68
69 private: 69 private:
70 // WebUIController 70 // WebUIController
71 virtual void RenderViewCreated( 71 void RenderViewCreated(content::RenderViewHost* render_view_host) override;
72 content::RenderViewHost* render_view_host) override;
73 72
74 // Gets the delegate for the WebContent set with SetDelegate. 73 // Gets the delegate for the WebContent set with SetDelegate.
75 static WebDialogDelegate* GetDelegate(content::WebContents* web_contents); 74 static WebDialogDelegate* GetDelegate(content::WebContents* web_contents);
76 75
77 // JS message handler. 76 // JS message handler.
78 void OnDialogClosed(const base::ListValue* args); 77 void OnDialogClosed(const base::ListValue* args);
79 78
80 DISALLOW_COPY_AND_ASSIGN(WebDialogUI); 79 DISALLOW_COPY_AND_ASSIGN(WebDialogUI);
81 }; 80 };
82 81
83 // Displays external URL contents inside a modal web dialog. 82 // Displays external URL contents inside a modal web dialog.
84 // 83 //
85 // Intended to be the place to collect the settings and lockdowns 84 // Intended to be the place to collect the settings and lockdowns
86 // necessary for running external UI components securely (e.g., the 85 // necessary for running external UI components securely (e.g., the
87 // cloud print dialog). 86 // cloud print dialog).
88 class WEB_DIALOGS_EXPORT ExternalWebDialogUI : public WebDialogUI { 87 class WEB_DIALOGS_EXPORT ExternalWebDialogUI : public WebDialogUI {
89 public: 88 public:
90 explicit ExternalWebDialogUI(content::WebUI* web_ui); 89 explicit ExternalWebDialogUI(content::WebUI* web_ui);
91 virtual ~ExternalWebDialogUI(); 90 ~ExternalWebDialogUI() override;
92 }; 91 };
93 92
94 } // namespace ui 93 } // namespace ui
95 94
96 #endif // UI_WEB_DIALOGS_WEB_DIALOG_UI_H_ 95 #endif // UI_WEB_DIALOGS_WEB_DIALOG_UI_H_
OLDNEW
« no previous file with comments | « ui/web_dialogs/test/test_web_dialog_delegate.h ('k') | ui/web_dialogs/web_dialog_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698