Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: ui/base/ime/input_method_base.h

Issue 667923002: Standardize usage of virtual/override/final in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/dummy_text_input_client.h ('k') | ui/base/ime/input_method_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_base.h
diff --git a/ui/base/ime/input_method_base.h b/ui/base/ime/input_method_base.h
index 76260e699844c0e0899bf9d7e28a08a85ce02815..8c6dd258d76ae094ed22ea2f1ee0847ab594aaa5 100644
--- a/ui/base/ime/input_method_base.h
+++ b/ui/base/ime/input_method_base.h
@@ -29,31 +29,31 @@ class UI_BASE_EXPORT InputMethodBase
public base::SupportsWeakPtr<InputMethodBase> {
public:
InputMethodBase();
- virtual ~InputMethodBase();
+ ~InputMethodBase() override;
// Overriden from InputMethod.
- virtual void SetDelegate(internal::InputMethodDelegate* delegate) override;
- virtual void Init(bool focused) override;
+ void SetDelegate(internal::InputMethodDelegate* delegate) override;
+ void Init(bool focused) override;
// If a derived class overrides OnFocus()/OnBlur(), it should call parent's
// implementation first, to make sure |system_toplevel_window_focused_| flag
// can be updated correctly.
- virtual void OnFocus() override;
- virtual void OnBlur() override;
- virtual void SetFocusedTextInputClient(TextInputClient* client) override;
- virtual void DetachTextInputClient(TextInputClient* client) override;
- virtual TextInputClient* GetTextInputClient() const override;
+ void OnFocus() override;
+ void OnBlur() override;
+ void SetFocusedTextInputClient(TextInputClient* client) override;
+ void DetachTextInputClient(TextInputClient* client) override;
+ TextInputClient* GetTextInputClient() const override;
// If a derived class overrides this method, it should call parent's
// implementation.
- virtual void OnTextInputTypeChanged(const TextInputClient* client) override;
+ void OnTextInputTypeChanged(const TextInputClient* client) override;
- virtual TextInputType GetTextInputType() const override;
- virtual TextInputMode GetTextInputMode() const override;
- virtual bool CanComposeInline() const override;
- virtual void ShowImeIfNeeded() override;
+ TextInputType GetTextInputType() const override;
+ TextInputMode GetTextInputMode() const override;
+ bool CanComposeInline() const override;
+ void ShowImeIfNeeded() override;
- virtual void AddObserver(InputMethodObserver* observer) override;
- virtual void RemoveObserver(InputMethodObserver* observer) override;
+ void AddObserver(InputMethodObserver* observer) override;
+ void RemoveObserver(InputMethodObserver* observer) override;
protected:
virtual void OnWillChangeFocusedClient(TextInputClient* focused_before,
« no previous file with comments | « ui/base/ime/dummy_text_input_client.h ('k') | ui/base/ime/input_method_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698