Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: ui/keyboard/keyboard_controller.h

Issue 667923002: Standardize usage of virtual/override/final in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/sync_control_vsync_provider.h ('k') | ui/message_center/cocoa/notification_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller.h
diff --git a/ui/keyboard/keyboard_controller.h b/ui/keyboard/keyboard_controller.h
index dc44cd648e4df69e2da89095ccf30e9984bd89f5..7a7b41a74b7254df2064c5f916b25b416abf724f 100644
--- a/ui/keyboard/keyboard_controller.h
+++ b/ui/keyboard/keyboard_controller.h
@@ -49,7 +49,7 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
// Takes ownership of |proxy|.
explicit KeyboardController(KeyboardControllerProxy* proxy);
- virtual ~KeyboardController();
+ ~KeyboardController() override;
// Returns the container for the keyboard, which is owned by
// KeyboardController.
@@ -115,21 +115,16 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
friend class KeyboardControllerTest;
// aura::WindowObserver overrides
- virtual void OnWindowHierarchyChanged(
- const HierarchyChangeParams& params) override;
+ void OnWindowHierarchyChanged(const HierarchyChangeParams& params) override;
// InputMethodObserver overrides
- virtual void OnTextInputTypeChanged(
- const ui::TextInputClient* client) override {}
- virtual void OnFocus() override {}
- virtual void OnBlur() override {}
- virtual void OnCaretBoundsChanged(
- const ui::TextInputClient* client) override {}
- virtual void OnTextInputStateChanged(
- const ui::TextInputClient* client) override;
- virtual void OnInputMethodDestroyed(
- const ui::InputMethod* input_method) override;
- virtual void OnShowImeIfNeeded() override;
+ void OnTextInputTypeChanged(const ui::TextInputClient* client) override {}
+ void OnFocus() override {}
+ void OnBlur() override {}
+ void OnCaretBoundsChanged(const ui::TextInputClient* client) override {}
+ void OnTextInputStateChanged(const ui::TextInputClient* client) override;
+ void OnInputMethodDestroyed(const ui::InputMethod* input_method) override;
+ void OnShowImeIfNeeded() override;
// Show virtual keyboard immediately with animation.
void ShowKeyboardInternal();
« no previous file with comments | « ui/gl/sync_control_vsync_provider.h ('k') | ui/message_center/cocoa/notification_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698