Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: ui/gl/gl_gl_api_implementation.h

Issue 667923002: Standardize usage of virtual/override/final in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_fence_nv.h ('k') | ui/gl/gl_image_io_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_gl_api_implementation.h
diff --git a/ui/gl/gl_gl_api_implementation.h b/ui/gl/gl_gl_api_implementation.h
index 39f95583bf1034876b653ca5bf6791548a49dd48..1b23097cbfa56e00d834f75b518025614285c0e5 100644
--- a/ui/gl/gl_gl_api_implementation.h
+++ b/ui/gl/gl_gl_api_implementation.h
@@ -42,7 +42,7 @@ class GLApiBase : public GLApi {
protected:
GLApiBase();
- virtual ~GLApiBase();
+ ~GLApiBase() override;
void InitializeBase(DriverGL* driver);
void SignalFlush();
@@ -53,19 +53,19 @@ class GLApiBase : public GLApi {
class RealGLApi : public GLApiBase {
public:
RealGLApi();
- virtual ~RealGLApi();
+ ~RealGLApi() override;
void Initialize(DriverGL* driver);
private:
- virtual void glFinishFn() override;
- virtual void glFlushFn() override;
+ void glFinishFn() override;
+ void glFlushFn() override;
};
// Inserts a TRACE for every GL call.
class TraceGLApi : public GLApi {
public:
TraceGLApi(GLApi* gl_api) : gl_api_(gl_api) { }
- virtual ~TraceGLApi();
+ ~TraceGLApi() override;
// Include the auto-generated part of this class. We split this because
// it means we can easily edit the non-auto generated parts right here in
@@ -80,7 +80,7 @@ class TraceGLApi : public GLApi {
class NoContextGLApi : public GLApi {
public:
NoContextGLApi();
- virtual ~NoContextGLApi();
+ ~NoContextGLApi() override;
// Include the auto-generated part of this class. We split this because
// it means we can easily edit the non-auto generated parts right here in
@@ -94,7 +94,7 @@ class NoContextGLApi : public GLApi {
class VirtualGLApi : public GLApiBase {
public:
VirtualGLApi();
- virtual ~VirtualGLApi();
+ ~VirtualGLApi() override;
void Initialize(DriverGL* driver, GLContext* real_context);
// Sets the current virutal context.
@@ -104,9 +104,9 @@ class VirtualGLApi : public GLApiBase {
private:
// Overridden functions from GLApiBase
- virtual const GLubyte* glGetStringFn(GLenum name) override;
- virtual void glFinishFn() override;
- virtual void glFlushFn() override;
+ const GLubyte* glGetStringFn(GLenum name) override;
+ void glFinishFn() override;
+ void glFlushFn() override;
// The real context we're running on.
GLContext* real_context_;
« no previous file with comments | « ui/gl/gl_fence_nv.h ('k') | ui/gl/gl_image_io_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698