Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ui/gfx/render_text_harfbuzz.h

Issue 667923002: Standardize usage of virtual/override/final in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/platform_font_mac.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.h
diff --git a/ui/gfx/render_text_harfbuzz.h b/ui/gfx/render_text_harfbuzz.h
index 329be9f9f10cf6bc1728d3034520ccf8e32c8146..c3508ff258c8da9d247bdb3ad71d4a31000f0344 100644
--- a/ui/gfx/render_text_harfbuzz.h
+++ b/ui/gfx/render_text_harfbuzz.h
@@ -77,31 +77,31 @@ struct GFX_EXPORT TextRunHarfBuzz {
class GFX_EXPORT RenderTextHarfBuzz : public RenderText {
public:
RenderTextHarfBuzz();
- virtual ~RenderTextHarfBuzz();
+ ~RenderTextHarfBuzz() override;
// Overridden from RenderText.
- virtual Size GetStringSize() override;
- virtual SizeF GetStringSizeF() override;
- virtual SelectionModel FindCursorPosition(const Point& point) override;
- virtual std::vector<FontSpan> GetFontSpansForTesting() override;
- virtual Range GetGlyphBounds(size_t index) override;
+ Size GetStringSize() override;
+ SizeF GetStringSizeF() override;
+ SelectionModel FindCursorPosition(const Point& point) override;
+ std::vector<FontSpan> GetFontSpansForTesting() override;
+ Range GetGlyphBounds(size_t index) override;
protected:
// Overridden from RenderText.
- virtual int GetLayoutTextBaseline() override;
- virtual SelectionModel AdjacentCharSelectionModel(
+ int GetLayoutTextBaseline() override;
+ SelectionModel AdjacentCharSelectionModel(
const SelectionModel& selection,
VisualCursorDirection direction) override;
- virtual SelectionModel AdjacentWordSelectionModel(
+ SelectionModel AdjacentWordSelectionModel(
const SelectionModel& selection,
VisualCursorDirection direction) override;
- virtual std::vector<Rect> GetSubstringBounds(const Range& range) override;
- virtual size_t TextIndexToLayoutIndex(size_t index) const override;
- virtual size_t LayoutIndexToTextIndex(size_t index) const override;
- virtual bool IsValidCursorIndex(size_t index) override;
- virtual void ResetLayout() override;
- virtual void EnsureLayout() override;
- virtual void DrawVisualText(Canvas* canvas) override;
+ std::vector<Rect> GetSubstringBounds(const Range& range) override;
+ size_t TextIndexToLayoutIndex(size_t index) const override;
+ size_t LayoutIndexToTextIndex(size_t index) const override;
+ bool IsValidCursorIndex(size_t index) override;
+ void ResetLayout() override;
+ void EnsureLayout() override;
+ void DrawVisualText(Canvas* canvas) override;
private:
friend class RenderTextTest;
« no previous file with comments | « ui/gfx/platform_font_mac.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698