Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses. (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Push isEqual/onIsEqual down from GrProcessor to subclasses. R=joshualitt@google.com Committed: https://skia.googlesource.com/skia/+/0e08fc17e4718f7ce4e38f793695896473e96948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -114 lines) Patch
M include/gpu/GrGeometryProcessor.h View 2 chunks +15 lines, -0 lines 0 comments Download
M include/gpu/GrProcessor.h View 4 chunks +27 lines, -27 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
bsalomon
The only interesting files are GrProcessor.h/cpp and GrGeometryProcessor.h. The rest are just changing param const ...
6 years, 2 months ago (2014-10-15 14:58:07 UTC) #1
joshua.litt
On 2014/10/15 14:58:07, bsalomon wrote: > The only interesting files are GrProcessor.h/cpp and GrGeometryProcessor.h. The ...
6 years, 2 months ago (2014-10-15 15:04:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654273002/1
6 years, 2 months ago (2014-10-15 15:12:06 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 15:19:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 0e08fc17e4718f7ce4e38f793695896473e96948

Powered by Google App Engine
This is Rietveld 408576698