src/gpu/effects/GrDitherEffect.cpp - Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrDitherEffect.cpp

Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrDitherEffect.cpp

diff --git a/src/gpu/effects/GrDitherEffect.cpp b/src/gpu/effects/GrDitherEffect.cpp

index 96cdd75048adbe379f024d5e5659ed31c2ffc0f1..0e7df5e73dfdf61e7691ab6f7050e6e4f35b61f0 100644

--- a/src/gpu/effects/GrDitherEffect.cpp

+++ b/src/gpu/effects/GrDitherEffect.cpp

@@ -40,7 +40,7 @@ private:

}

// All dither effects are equal

- virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE { return true; }

+ virtual bool onIsEqual(const GrFragmentProcessor&) const SK_OVERRIDE { return true; }

virtual void onComputeInvariantOutput(InvariantOutput* inout) const SK_OVERRIDE;