src/effects/SkMorphologyImageFilter.cpp - Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMorphologyImageFilter.cpp

Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMorphologyImageFilter.cpp

diff --git a/src/effects/SkMorphologyImageFilter.cpp b/src/effects/SkMorphologyImageFilter.cpp

index 6c3e6f6dc7633d9ee468bcdf14c1603130a2daf8..95cf85e8002d75e3596b852fb6d5c041f443197e 100644

--- a/src/effects/SkMorphologyImageFilter.cpp

+++ b/src/effects/SkMorphologyImageFilter.cpp

@@ -315,7 +315,7 @@ protected:

MorphologyType fType;

private:

- virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE;

+ virtual bool onIsEqual(const GrFragmentProcessor&) const SK_OVERRIDE;

virtual void onComputeInvariantOutput(InvariantOutput* inout) const SK_OVERRIDE;

@@ -448,7 +448,7 @@ const GrBackendFragmentProcessorFactory& GrMorphologyEffect::getFactory() const

return GrTBackendFragmentProcessorFactory<GrMorphologyEffect>::getInstance();

}

-bool GrMorphologyEffect::onIsEqual(const GrProcessor& sBase) const {

+bool GrMorphologyEffect::onIsEqual(const GrFragmentProcessor& sBase) const {

const GrMorphologyEffect& s = sBase.cast<GrMorphologyEffect>();

return (this->texture(0) == s.texture(0) &&

this->radius() == s.radius() &&

« no previous file with comments | « src/effects/SkMagnifierImageFilter.cpp ('k') | src/effects/SkPerlinNoiseShader.cpp » ('j') | no next file with comments »