src/effects/gradients/SkTwoPointRadialGradient.cpp - Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkTwoPointRadialGradient.cpp

Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkTwoPointRadialGradient.cpp

diff --git a/src/effects/gradients/SkTwoPointRadialGradient.cpp b/src/effects/gradients/SkTwoPointRadialGradient.cpp

index d83a937a66bfe64828ad560bb43eb9f9559f2e7a..3680665830c4b6fd931246bf9f5982bfb468d27b 100644

--- a/src/effects/gradients/SkTwoPointRadialGradient.cpp

+++ b/src/effects/gradients/SkTwoPointRadialGradient.cpp

@@ -473,7 +473,7 @@ public:

typedef GrGLRadial2Gradient GLProcessor;

private:

- virtual bool onIsEqual(const GrProcessor& sBase) const SK_OVERRIDE {

+ virtual bool onIsEqual(const GrFragmentProcessor& sBase) const SK_OVERRIDE {

const GrRadial2Gradient& s = sBase.cast<GrRadial2Gradient>();

return (INHERITED::onIsEqual(sBase) &&

this->fCenterX1 == s.fCenterX1 &&