src/gpu/effects/GrConvolutionEffect.cpp - Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConvolutionEffect.cpp

Issue 654273002: Push isEqual/onIsEqual down from GrProcessor to subclasses. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConvolutionEffect.cpp

diff --git a/src/gpu/effects/GrConvolutionEffect.cpp b/src/gpu/effects/GrConvolutionEffect.cpp

index 01c56f1163b3939cc98c14147990d4e6b60f040d..9776a2af5f67e65eb7e05848541cc29bfc3b3813 100644

--- a/src/gpu/effects/GrConvolutionEffect.cpp

+++ b/src/gpu/effects/GrConvolutionEffect.cpp

@@ -200,7 +200,7 @@ const GrBackendFragmentProcessorFactory& GrConvolutionEffect::getFactory() const

return GrTBackendFragmentProcessorFactory<GrConvolutionEffect>::getInstance();

}

-bool GrConvolutionEffect::onIsEqual(const GrProcessor& sBase) const {

+bool GrConvolutionEffect::onIsEqual(const GrFragmentProcessor& sBase) const {

const GrConvolutionEffect& s = sBase.cast<GrConvolutionEffect>();

return (this->texture(0) == s.texture(0) &&

this->radius() == s.radius() &&

« no previous file with comments | « src/gpu/effects/GrConvolutionEffect.h ('k') | src/gpu/effects/GrCustomCoordsTextureEffect.h » ('j') | no next file with comments »