Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

By using base::ScopedFD, the ownership of the returned FD becomes
clearer.

BUG=415294
R=brettw@chromium.org, jam@chromium.org, yzshen@chromium.org, sehr@chromium.org
TBR=gene@chromium.org

Committed: https://crrev.com/a409ccc3182ae1cb91fe7937a6c60f8d80755436
Cr-Commit-Position: refs/heads/master@{#300381}

[jam, 2014-10-02 06:18:12]

jam@chromium.org changed reviewers:
+ creis@chromium.org
- jam@chromium.org

[jam, 2014-10-02 06:18:13]

Charlie: can you look at this please? I'm overloaded, thanks.

[Charlie Reis, 2014-10-02 17:33:46]

I don't have all the context, but I like that it's making the ownership clearer.
content/ LGTM.

[brettw, 2014-10-02 17:55:40]

base lgtm, didn't look at the rest.

[sehr, 2014-10-10 17:47:07]

nacl parts LGTM.

[Hajime Morrita, 2014-10-20 21:15:38]

morrita@chromium.org changed reviewers:
+ agl@chromium.org

[Hajime Morrita, 2014-10-20 21:18:47]

morrita@chromium.org changed reviewers:
+ dmichael@chromium.org

[Hajime Morrita, 2014-10-20 21:18:47]

agl: Could you take a look at ipc/?
Dave: Rubberstamp ppapi/ please?

[agl, 2014-10-20 21:26:45]

ipc/ LGTM

[dmichael (off chromium), 2014-10-20 22:34:41]

ppapi lgtm

https://codereview.chromium.org/621613002/diff/50001/ppapi/proxy/proxy_channel.h
File ppapi/proxy/proxy_channel.h (right):

https://codereview.chromium.org/621613002/diff/50001/ppapi/proxy/proxy_channe...
ppapi/proxy/proxy_channel.h:8: #include "base/files/scoped_file.h"
optional nit: It should be possible to make a forward declaration of ScopedFD
instead of having an include in the header.

[Hajime Morrita, 2014-10-20 22:49:53]

https://codereview.chromium.org/621613002/diff/50001/ppapi/proxy/proxy_channel.h
File ppapi/proxy/proxy_channel.h (right):

https://codereview.chromium.org/621613002/diff/50001/ppapi/proxy/proxy_channe...
ppapi/proxy/proxy_channel.h:8: #include "base/files/scoped_file.h"
On 2014/10/20 22:34:40, dmichael wrote:
> optional nit: It should be possible to make a forward declaration of ScopedFD
> instead of having an include in the header.

Tried, but turned out the type is a typedef of a template and
cannot capture in one line typedef. Let me include it.

[Hajime Morrita, 2014-10-20 22:51:43]

morrita@chromium.org changed reviewers:
+ gene@chromium.org

[Hajime Morrita, 2014-10-20 22:51:49]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-10-20 22:53:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/621613002/50001

[commit-bot: I haz the power, 2014-10-20 23:53:39]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2014-10-20 23:54:20]

Patchset 3 (id:??) landed as
https://crrev.com/a409ccc3182ae1cb91fe7937a6c60f8d80755436
Cr-Commit-Position: refs/heads/master@{#300381}