ppapi/proxy/proxy_channel.h - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/proxy_channel.h

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/proxy_channel.h

diff --git a/ppapi/proxy/proxy_channel.h b/ppapi/proxy/proxy_channel.h

index 873bc09f0f989401449fbcb33b774f6db92d650c..97069beb36723ecffb3fbbed2edd3bb46a8a320d 100644

--- a/ppapi/proxy/proxy_channel.h

+++ b/ppapi/proxy/proxy_channel.h

@@ -5,6 +5,7 @@

#ifndef PPAPI_PROXY_PROXY_CHANNEL_H_

#define PPAPI_PROXY_PROXY_CHANNEL_H_

+#include "base/files/scoped_file.h"

dmichael (off chromium) 2014/10/20 22:34:40 optional nit: It should be possible to make a forw

Hajime Morrita 2014/10/20 22:49:53 Tried, but turned out the type is a typedef of a t

#include "base/memory/scoped_ptr.h"

#include "base/process/process.h"

#include "ipc/ipc_listener.h"

@@ -81,7 +82,7 @@ class PPAPI_PROXY_EXPORT ProxyChannel

}

#if defined(OS_POSIX) && !defined(OS_NACL)

- int TakeRendererFD();

+ base::ScopedFD TakeRendererFD();

#endif

protected:

« no previous file with comments | « ipc/mojo/ipc_mojo_bootstrap.cc ('k') | ppapi/proxy/proxy_channel.cc » ('j') | no next file with comments »