content/public/common/sandboxed_process_launcher_delegate.h - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/sandboxed_process_launcher_delegate.h

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/common/sandboxed_process_launcher_delegate.h

diff --git a/content/public/common/sandboxed_process_launcher_delegate.h b/content/public/common/sandboxed_process_launcher_delegate.h

index 3f634a159f3993059535c886df70bdf834fcb094..134fc0f58efe42d2d61ae58367fc716129be53c2 100644

--- a/content/public/common/sandboxed_process_launcher_delegate.h

+++ b/content/public/common/sandboxed_process_launcher_delegate.h

@@ -6,8 +6,8 @@

#define CONTENT_PUBLIC_COMMON_SANDBOXED_PROCESS_LAUNCHER_DELEGATE_H_

#include "base/environment.h"

+#include "base/files/scoped_file.h"

#include "base/process/process.h"

#include "content/common/content_export.h"

#if defined(OS_MACOSX)

@@ -64,7 +64,7 @@ class CONTENT_EXPORT SandboxedProcessLauncherDelegate {

virtual base::EnvironmentMap GetEnvironment();

// Return the file descriptor for the IPC channel.

- virtual int GetIpcFd() = 0;

+ virtual base::ScopedFD TakeIpcFd() = 0;

#if defined(OS_MACOSX)

// Gets the Mac SandboxType to enforce on the process. Return

« no previous file with comments | « content/public/common/child_process_host.h ('k') | ipc/ipc_channel.h » ('j') | ppapi/proxy/proxy_channel.h » ('J')