content/ppapi_plugin/ppapi_thread.cc - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/ppapi_plugin/ppapi_thread.cc

diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc

index 142f64760c710a207ffcf067b0dc3c1023c06378..45d8951fe676e860bad0a837898b1c662d9f936b 100644

--- a/content/ppapi_plugin/ppapi_thread.cc

+++ b/content/ppapi_plugin/ppapi_thread.cc

@@ -492,7 +492,7 @@ bool PpapiThread::SetupRendererChannel(base::ProcessId renderer_pid,

// On POSIX, transfer ownership of the renderer-side (client) FD.

// This ensures this process will be notified when it is closed even if a

// connection is not established.

- handle->socket = base::FileDescriptor(dispatcher->TakeRendererFD(), true);

+ handle->socket = base::FileDescriptor(dispatcher->TakeRendererFD());

if (handle->socket.fd == -1)

return false;

#endif

« no previous file with comments | « content/plugin/plugin_thread.cc ('k') | content/public/common/child_process_host.h » ('j') | ppapi/proxy/proxy_channel.h » ('J')