ipc/ipc_channel_proxy.cc - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_proxy.cc

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_proxy.cc

diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc

index f74dc83a4133b926c4aa67ddd04d1442dd2db6da..e2d7ad473cb1caa1bdd64f5460eff9be78a017f3 100644

--- a/ipc/ipc_channel_proxy.cc

+++ b/ipc/ipc_channel_proxy.cc

@@ -446,7 +446,7 @@ int ChannelProxy::GetClientFileDescriptor() {

return channel->GetClientFileDescriptor();

}

-int ChannelProxy::TakeClientFileDescriptor() {

+base::ScopedFD ChannelProxy::TakeClientFileDescriptor() {

DCHECK(CalledOnValidThread());

Channel* channel = context_.get()->channel_.get();

« no previous file with comments | « ipc/ipc_channel_proxy.h ('k') | ipc/ipc_send_fds_test.cc » ('j') | ppapi/proxy/proxy_channel.h » ('J')