ipc/mojo/ipc_channel_mojo.h - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/mojo/ipc_channel_mojo.h

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/mojo/ipc_channel_mojo.h

diff --git a/ipc/mojo/ipc_channel_mojo.h b/ipc/mojo/ipc_channel_mojo.h

index 696d744cd59a3c1cd41df38e98c68e588d1c5685..4752fabed99d49e8766c9b96e840ce9bbfb9aa90 100644

--- a/ipc/mojo/ipc_channel_mojo.h

+++ b/ipc/mojo/ipc_channel_mojo.h

@@ -98,7 +98,7 @@ class IPC_MOJO_EXPORT ChannelMojo : public Channel,

#if defined(OS_POSIX) && !defined(OS_NACL)

virtual int GetClientFileDescriptor() const override;

- virtual int TakeClientFileDescriptor() override;

+ virtual base::ScopedFD TakeClientFileDescriptor() override;

// These access protected API of IPC::Message, which has ChannelMojo

// as a friend class.

« no previous file with comments | « ipc/ipc_test_sink.cc ('k') | ipc/mojo/ipc_channel_mojo.cc » ('j') | ppapi/proxy/proxy_channel.h » ('J')