Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: content/common/child_process_host_impl.h

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing Mac build Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_COMMON_CHILD_PROCESS_HOST_IMPL_H_ 5 #ifndef CONTENT_COMMON_CHILD_PROCESS_HOST_IMPL_H_
6 #define CONTENT_COMMON_CHILD_PROCESS_HOST_IMPL_H_ 6 #define CONTENT_COMMON_CHILD_PROCESS_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 // This will never return ChildProcessHost::kInvalidUniqueID. 54 // This will never return ChildProcessHost::kInvalidUniqueID.
55 static int GenerateChildProcessUniqueId(); 55 static int GenerateChildProcessUniqueId();
56 56
57 // ChildProcessHost implementation 57 // ChildProcessHost implementation
58 virtual bool Send(IPC::Message* message) override; 58 virtual bool Send(IPC::Message* message) override;
59 virtual void ForceShutdown() override; 59 virtual void ForceShutdown() override;
60 virtual std::string CreateChannel() override; 60 virtual std::string CreateChannel() override;
61 virtual bool IsChannelOpening() override; 61 virtual bool IsChannelOpening() override;
62 virtual void AddFilter(IPC::MessageFilter* filter) override; 62 virtual void AddFilter(IPC::MessageFilter* filter) override;
63 #if defined(OS_POSIX) 63 #if defined(OS_POSIX)
64 virtual int TakeClientFileDescriptor() override; 64 virtual base::ScopedFD TakeClientFileDescriptor() override;
65 #endif 65 #endif
66 66
67 private: 67 private:
68 friend class ChildProcessHost; 68 friend class ChildProcessHost;
69 69
70 explicit ChildProcessHostImpl(ChildProcessHostDelegate* delegate); 70 explicit ChildProcessHostImpl(ChildProcessHostDelegate* delegate);
71 71
72 // IPC::Listener methods: 72 // IPC::Listener methods:
73 virtual bool OnMessageReceived(const IPC::Message& msg) override; 73 virtual bool OnMessageReceived(const IPC::Message& msg) override;
74 virtual void OnChannelConnected(int32 peer_pid) override; 74 virtual void OnChannelConnected(int32 peer_pid) override;
(...skipping 25 matching lines...) Expand all
100 // thread, we don't have a IPC::ChannelProxy and so we manage filters 100 // thread, we don't have a IPC::ChannelProxy and so we manage filters
101 // manually. 101 // manually.
102 std::vector<scoped_refptr<IPC::MessageFilter> > filters_; 102 std::vector<scoped_refptr<IPC::MessageFilter> > filters_;
103 103
104 DISALLOW_COPY_AND_ASSIGN(ChildProcessHostImpl); 104 DISALLOW_COPY_AND_ASSIGN(ChildProcessHostImpl);
105 }; 105 };
106 106
107 } // namespace content 107 } // namespace content
108 108
109 #endif // CONTENT_COMMON_CHILD_PROCESS_HOST_IMPL_H_ 109 #endif // CONTENT_COMMON_CHILD_PROCESS_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698