Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

ppapi/proxy/proxy_channel.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_PROXY_PROXY_CHANNEL_H_
 #define PPAPI_PROXY_PROXY_CHANNEL_H_
 
+#include "base/files/scoped_file.h"

[dmichael (off chromium), 2014/10/20 22:34:40]

optional nit: It should be possible to make a forward declaration of ScopedFD
instead of having an include in the header.

[Hajime Morrita, 2014/10/20 22:49:53]

Tried, but turned out the type is a typedef of a template and
cannot capture in one line typedef. Let me include it.

 #include "base/memory/scoped_ptr.h"
 #include "base/process/process.h"
 #include "ipc/ipc_listener.h"
 #include "ipc/ipc_platform_file.h"
 #include "ipc/ipc_sender.h"
 #include "ipc/ipc_sync_channel.h"
 #include "ppapi/proxy/ppapi_proxy_export.h"
 
 namespace base {
 class MessageLoopProxy;
@@ skipping 56 matching lines @@
 
   // IPC::Listener implementation.
   virtual void OnChannelError() override;
 
   // Will be NULL in some unit tests and if the remote side has crashed.
   IPC::SyncChannel* channel() const {
     return channel_.get();
   }
 
 #if defined(OS_POSIX) && !defined(OS_NACL)
-  int TakeRendererFD();
+  base::ScopedFD TakeRendererFD();
 #endif
 
  protected:
   explicit ProxyChannel();
 
   // You must call this function before anything else. Returns true on success.
   // The delegate pointer must outlive this class, ownership is not
   // transferred.
   virtual bool InitWithChannel(Delegate* delegate,
                                base::ProcessId peer_pid,
@@ skipping 22 matching lines @@
   // remote side has crashed.
   scoped_ptr<IPC::SyncChannel> channel_;
 
   DISALLOW_COPY_AND_ASSIGN(ProxyChannel);
 };
 
 }  // namespace proxy
 }  // namespace ppapi
 
 #endif  // PPAPI_PROXY_PROXY_CHANNEL_H_