ipc/ipc_channel.h - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel.h

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel.h

diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h

index f6bd5044c14af5150e12a9a964a382d7d630c4cc..a7982e5554f1f719270831680748c8d5ef2f0d87 100644

--- a/ipc/ipc_channel.h

+++ b/ipc/ipc_channel.h

@@ -12,6 +12,7 @@

#endif

#include "base/compiler_specific.h"

+#include "base/files/scoped_file.h"

#include "base/process/process.h"

#include "ipc/ipc_channel_handle.h"

#include "ipc/ipc_message.h"

@@ -189,7 +190,7 @@ class IPC_EXPORT Channel : public Sender {

// Same as GetClientFileDescriptor, but transfers the ownership of the

// file descriptor to the caller.

// This method can be called on any thread.

- virtual int TakeClientFileDescriptor() = 0;

+ virtual base::ScopedFD TakeClientFileDescriptor() = 0;

#endif // defined(OS_POSIX) && !defined(OS_NACL)

// Returns true if a named server channel is initialized on the given channel

« no previous file with comments | « content/public/common/sandboxed_process_launcher_delegate.h ('k') | ipc/ipc_channel_posix.h » ('j') | ppapi/proxy/proxy_channel.h » ('J')