components/nacl/browser/nacl_process_host.cc - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc ('k') | components/nacl/loader/nacl_ipc_adapter.h » ('j') | ppapi/proxy/proxy_channel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/browser/nacl_process_host.cc

diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc

index 3b6ddcf7050d0caa0f59588b5e4854146e7b4984..00c1201e2ffc0083e8597aa01258d61f261d7e5d 100644

--- a/components/nacl/browser/nacl_process_host.cc

+++ b/components/nacl/browser/nacl_process_host.cc

@@ -179,14 +179,14 @@ class NaClSandboxedProcessLauncherDelegate

virtual bool ShouldUseZygote() override {

return true;

}

- virtual int GetIpcFd() override {

- return ipc_fd_;

+ virtual base::ScopedFD TakeIpcFd() override {

+ return ipc_fd_.Pass();

}

#endif // OS_WIN

private:

#if defined(OS_POSIX)

- int ipc_fd_;

+ base::ScopedFD ipc_fd_;

#endif // OS_POSIX

};