components/nacl/loader/nacl_ipc_adapter.h - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_ipc_adapter.h

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/loader/nacl_ipc_adapter.h

diff --git a/components/nacl/loader/nacl_ipc_adapter.h b/components/nacl/loader/nacl_ipc_adapter.h

index 84e756d881f07c5e666affb7fb8141b738c5753b..a18aed7959d9aef541e581389c510f92a5bba8af 100644

--- a/components/nacl/loader/nacl_ipc_adapter.h

+++ b/components/nacl/loader/nacl_ipc_adapter.h

@@ -12,6 +12,7 @@

#include "base/basictypes.h"

#include "base/callback.h"

+#include "base/files/scoped_file.h"

#include "base/memory/ref_counted.h"

#include "base/memory/scoped_ptr.h"

#include "base/memory/scoped_vector.h"

@@ -106,7 +107,7 @@ class NaClIPCAdapter : public base::RefCountedThreadSafe<NaClIPCAdapter>,

NaClDesc* MakeNaClDesc();

#if defined(OS_POSIX)

- int TakeClientFileDescriptor();

+ base::ScopedFD TakeClientFileDescriptor();

#endif

// Listener implementation.

« no previous file with comments | « components/nacl/browser/nacl_process_host.cc ('k') | components/nacl/loader/nacl_ipc_adapter.cc » ('j') | ppapi/proxy/proxy_channel.h » ('J')