chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc - Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 621613002: Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing Mac build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

index a6fc19e6e4f1b214505298adb472e093e9955b39..1ffdd53beecf69bc8aa0475b796f344a683feb9e 100644

--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

@@ -450,7 +450,7 @@ base::ProcessHandle CloudPrintProxyPolicyStartupTest::Launch(

#if defined(OS_POSIX)

base::FileHandleMappingVector ipc_file_list;

ipc_file_list.push_back(std::make_pair(

- startup_channel_->TakeClientFileDescriptor(),

+ startup_channel_->TakeClientFileDescriptor().release(),

kPrimaryIPCChannel + base::GlobalDescriptors::kBaseDescriptor));

base::LaunchOptions options;

options.fds_to_remap = &ipc_file_list;

« no previous file with comments | « base/file_descriptor_posix.h ('k') | components/nacl/browser/nacl_process_host.cc » ('j') | ppapi/proxy/proxy_channel.h » ('J')