Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
Committed: https://crrev.com/c704794140dcfe95c002c7b0bfd7361f33088190
Cr-Commit-Position: refs/heads/master@{#291844}

[dcheng, 2014-08-26 01:15:28]

dcheng@chromium.org changed reviewers:
+ yoz@chromium.org

[dcheng, 2014-08-26 01:15:28]

Unfortunately, we can't make scoped_refptr testable until the conversion
operator has been removed. While it would be possible to disable the conversion
operator and make it testable in the same patch, the automated tool tries to
skip rewriting code where manual cleanups would be useful. This includes things
like:

// What if ReturnsScopedRefPtr() creates a new object internally?
if (ReturnsScopedRefPtr())

Foo* Bar() {
  const scoped_refptr<Foo>& f = ReturnsScopedRefPtr();
  return f;  // Does the return type need to be rewritten? Or is .get() safe?
}

Doing this in one patch would make catching some of these instances (in
particular, a boolean test on a temporary scoped_refptr) more difficult. As a
result, the work is being split into several steps:
Step 1: Rewrite all implicit conversions to be explicit (or rewrite the receiver
type to scoped_refptr<T>, if the tool believes the conversion to be unsafe).
Step 2: Once a platform compiles cleanly without the conversion operator, #ifdef
the conversion operator out.
Step 3: Make scoped_refptr testable on that platform.
Step 4: Remove unnecessary calls to .get().

https://codereview.chromium.org/508513002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_messages_apitest.cc (right):

https://codereview.chromium.org/508513002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_messages_apitest.cc:480: scoped_refptr<const
Extension> chromium_connectable =
Note: this variable type (and other instances in this test) was rewritten
because Load*Extension()'s returns a scoped_refptr<T>. Assigning this directly
to a raw pointer means that there might no longer be a reference once this line
finishes executing, since the temporary scoped_refptr<T> will be destroyed.

Please let me know if you'd like me to do something else here.

https://codereview.chromium.org/508513002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_ui_unittest.cc (right):

https://codereview.chromium.org/508513002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_ui_unittest.cc:79: const scoped_refptr<const
Extension> CreateExtension(
Note: this return type (and other instances in this test) was rewritten instead
of simply adding .get(), because generally speaking, there is no way of
determining if this is safe or not (obviously the existing code works, but it's
potentially dangerous--the only obvious reference is on the stack, which is lost
once the function returns).

Please let me know if you'd like me to take another action here, and I'm happy
to update the code accordingly.

https://codereview.chromium.org/508513002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_ui_unittest.cc:324: scoped_refptr<const
Extension> all_urls_extension = CreateExtension(
Note: this variable type (and other instances in this test) was rewritten
because CreateExtension()'s return type changed to scoped_refptr<T>. Assigning
this directly to a raw pointer means that there might no longer be a reference
once this line finishes executing, since the temporary scoped_refptr<T> will be
destroyed.

Please let me know if you'd like me to do something else here.

[dcheng, 2014-08-26 01:30:18]

https://codereview.chromium.org/508513002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/webstore_standalone_installer.cc (right):

https://codereview.chromium.org/508513002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/webstore_standalone_installer.cc:352:
scoped_refptr<const Extension> extension_to_install =
Note: I missed this in my original overview of the patch, but I had to change
the variable type here as well.

[Yoyo Zhou, 2014-08-26 02:04:28]

LGTM

[dcheng, 2014-08-26 02:10:25]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-26 02:12:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/508513002/40001

[commit-bot: I haz the power, 2014-08-26 02:59:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-26 05:05:44]

Committed patchset #3 (40001) as e40f0664f1b461f4a53a3410decb2282c3856e52

[commit-bot: I haz the power, 2014-09-10 02:40:37]

Patchset 3 (id:??) landed as
https://crrev.com/c704794140dcfe95c002c7b0bfd7361f33088190
Cr-Commit-Position: refs/heads/master@{#291844}