chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/blacklist_state_fetcher.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

diff --git a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

index aba1f6f0a03066dbef5a0859934a09dd7dbb0cee..422194c31840de0a8e2c1a4a5fb334539b67b02c 100644

--- a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

+++ b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

@@ -75,14 +75,14 @@ TEST_F(BrowserPermissionsPolicyDelegateTest, CanExecuteScriptOnPage) {

// The same call should succeed with a normal process, but fail with a signin

// process.

const PermissionsData* permissions_data = extension->permissions_data();

- EXPECT_TRUE(permissions_data->CanAccessPage(extension,

+ EXPECT_TRUE(permissions_data->CanAccessPage(extension.get(),

kSigninUrl,

-1, // no tab id.

normal_process.GetID(),

&error))

<< error;

- EXPECT_FALSE(permissions_data->CanAccessPage(extension,

+ EXPECT_FALSE(permissions_data->CanAccessPage(extension.get(),

kSigninUrl,

-1, // no tab id.