chrome/browser/extensions/settings_api_helpers.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings_api_helpers.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/sandboxed_unpacker.cc ('k') | chrome/browser/extensions/shared_module_service_unittest.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/settings_api_helpers.cc

diff --git a/chrome/browser/extensions/settings_api_helpers.cc b/chrome/browser/extensions/settings_api_helpers.cc

index df73df2387530a811fcd515e45274bcbe9a984ff..2fcd9c8670c4f0c7dc0818e21bd8d8ad3342453b 100644

--- a/chrome/browser/extensions/settings_api_helpers.cc

+++ b/chrome/browser/extensions/settings_api_helpers.cc

@@ -27,7 +27,7 @@ const Extension* FindOverridingExtension(

for (ExtensionSet::const_iterator it = extensions.begin();

it != extensions.end();

++it) {

- const SettingsOverrides* settings = SettingsOverrides::Get(*it);

+ const SettingsOverrides* settings = SettingsOverrides::Get(it->get());

if (settings) {

if (type == BUBBLE_TYPE_HOME_PAGE && !settings->homepage)

continue;

@@ -56,7 +56,7 @@ const Extension* FindOverridingExtension(

continue; // Not primary.

// Found the primary extension.

- return *it;

+ return it->get();

}