chrome/browser/extensions/error_console/error_console_unittest.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console_unittest.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_action_manager_unittest.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/error_console/error_console_unittest.cc

diff --git a/chrome/browser/extensions/error_console/error_console_unittest.cc b/chrome/browser/extensions/error_console/error_console_unittest.cc

index d330cbfd1ba23731ff448151a6072d28e1a28a7c..b6f18abd98c3f9b876d84911f892f591f21a645e 100644

--- a/chrome/browser/extensions/error_console/error_console_unittest.cc

+++ b/chrome/browser/extensions/error_console/error_console_unittest.cc

@@ -111,14 +111,14 @@ TEST_F(ErrorConsoleUnitTest, EnableAndDisableErrorConsole) {

.Build();

ExtensionRegistry* registry = ExtensionRegistry::Get(profile_.get());

registry->AddEnabled(adt);

- registry->TriggerOnLoaded(adt);

+ registry->TriggerOnLoaded(adt.get());

EXPECT_TRUE(error_console_->enabled());

EXPECT_FALSE(error_console_->IsEnabledForChromeExtensionsPage());

EXPECT_TRUE(error_console_->IsEnabledForAppsDeveloperTools());

// Unloading the Apps Developer Tools should disable error console.

registry->RemoveEnabled(adt->id());

- registry->TriggerOnUnloaded(adt, UnloadedExtensionInfo::REASON_DISABLE);

+ registry->TriggerOnUnloaded(adt.get(), UnloadedExtensionInfo::REASON_DISABLE);

EXPECT_FALSE(error_console_->enabled());

EXPECT_FALSE(error_console_->IsEnabledForChromeExtensionsPage());

EXPECT_FALSE(error_console_->IsEnabledForAppsDeveloperTools());