chrome/browser/extensions/install_verifier.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/install_verifier.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/extensions/installed_loader.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/install_verifier.cc

diff --git a/chrome/browser/extensions/install_verifier.cc b/chrome/browser/extensions/install_verifier.cc

index ebd3a8d82f531fdf1b63ff5aed614c620f5bcaf5..7ef862fec0bf7e3e6b92c2be703fd136a5477288 100644

--- a/chrome/browser/extensions/install_verifier.cc

+++ b/chrome/browser/extensions/install_verifier.cc

@@ -446,7 +446,7 @@ ExtensionIdSet InstallVerifier::GetExtensionsToVerify() const {

for (ExtensionSet::const_iterator iter = extensions->begin();

iter != extensions->end();

++iter) {

- if (NeedsVerification(**iter))

+ if (NeedsVerification(*iter->get()))

result.insert((*iter)->id());

}

return result;

@@ -494,7 +494,7 @@ void InstallVerifier::OnVerificationComplete(bool success, OperationType type) {

++iter) {

int disable_reasons = prefs_->GetDisableReasons((*iter)->id());

if (disable_reasons & Extension::DISABLE_NOT_VERIFIED &&

- !MustRemainDisabled(*iter, NULL, NULL)) {

+ !MustRemainDisabled(iter->get(), NULL, NULL)) {

prefs_->RemoveDisableReason((*iter)->id(),

Extension::DISABLE_NOT_VERIFIED);

}