chrome/browser/extensions/location_bar_controller.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/location_bar_controller.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/location_bar_controller.cc

diff --git a/chrome/browser/extensions/location_bar_controller.cc b/chrome/browser/extensions/location_bar_controller.cc

index 9bdc73645f835e183dbe95ede1ea8331787ed124..4d07cdf3b7b27e757994453e332c257635948be3 100644

--- a/chrome/browser/extensions/location_bar_controller.cc

+++ b/chrome/browser/extensions/location_bar_controller.cc

@@ -47,9 +47,9 @@ std::vector<ExtensionAction*> LocationBarController::GetCurrentActions() {

// one action per extension. If clicking on an active script action ever

// has a response, then we will need to split the actions.

ExtensionAction* action =

- page_action_controller_->GetActionForExtension(*iter);

+ page_action_controller_->GetActionForExtension(iter->get());

if (!action)

- action = active_script_controller_->GetActionForExtension(*iter);

+ action = active_script_controller_->GetActionForExtension(iter->get());

if (action)

current_actions.push_back(action);

}