chrome/browser/extensions/active_tab_unittest.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_unittest.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_script_controller_unittest.cc ('k') | chrome/browser/extensions/blacklist.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_tab_unittest.cc

diff --git a/chrome/browser/extensions/active_tab_unittest.cc b/chrome/browser/extensions/active_tab_unittest.cc

index b360fbd35f51effeba04c73f68a1c42b7d685926..efa00dc39c6f6eb31010a2593130d04925c6d601 100644

--- a/chrome/browser/extensions/active_tab_unittest.cc

+++ b/chrome/browser/extensions/active_tab_unittest.cc

@@ -108,8 +108,8 @@ class ActiveTabTest : public ChromeRenderViewHostTestHarness {

PermittedFeature feature,

int tab_id) {

const PermissionsData* permissions_data = extension->permissions_data();

- bool script =

- permissions_data->CanAccessPage(extension, url, url, tab_id, -1, NULL);

+ bool script = permissions_data->CanAccessPage(

+ extension.get(), url, url, tab_id, -1, NULL);

bool capture = HasTabsPermission(extension, tab_id) &&

permissions_data->CanCaptureVisiblePage(tab_id, NULL);

switch (feature) {