chrome/browser/extensions/external_install_error.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_error.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_ui_unittest.cc ('k') | chrome/browser/extensions/external_provider_impl.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_install_error.cc

diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc

index 0ed176cee4ae1d3f0a588c460a670a6365e3dbd0..c01e8da854fac0db1f97bc682bc7eb487222a13e 100644

--- a/chrome/browser/extensions/external_install_error.cc

+++ b/chrome/browser/extensions/external_install_error.cc

@@ -369,7 +369,7 @@ void ExternalInstallError::OnDialogReady(

prompt_ = prompt;

if (alert_type_ == BUBBLE_ALERT) {

- global_error_.reset(new ExternalInstallBubbleAlert(this, prompt_));

+ global_error_.reset(new ExternalInstallBubbleAlert(this, prompt_.get()));

error_service_->AddGlobalError(global_error_.get());

Browser* browser =