Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: chrome/browser/extensions/extension_install_prompt.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Two more Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.cc
diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc
index 82745c954328c4fe9b9794a1b87f8de23c7fdd18..dec1aa54f3b756b3d1ba147b74b8179e6c912cf0 100644
--- a/chrome/browser/extensions/extension_install_prompt.cc
+++ b/chrome/browser/extensions/extension_install_prompt.cc
@@ -311,8 +311,8 @@ int ExtensionInstallPrompt::Prompt::GetDialogButtons() const {
}
bool ExtensionInstallPrompt::Prompt::ShouldShowExplanationText() const {
- return type_ == INSTALL_PROMPT &&
- extension_->is_extension() && experiment_ && experiment_->text_only();
+ return type_ == INSTALL_PROMPT && extension_->is_extension() &&
+ experiment_.get() && experiment_->text_only();
}
bool ExtensionInstallPrompt::Prompt::HasAcceptButtonLabel() const {
@@ -748,9 +748,9 @@ void ExtensionInstallPrompt::ShowConfirmation() {
const extensions::PermissionMessageProvider* message_provider =
extensions::PermissionMessageProvider::Get();
prompt_->SetPermissions(
- message_provider->GetWarningMessages(permissions_, type));
+ message_provider->GetWarningMessages(permissions_.get(), type));
prompt_->SetPermissionsDetails(
- message_provider->GetWarningMessagesDetails(permissions_, type));
+ message_provider->GetWarningMessagesDetails(permissions_.get(), type));
}
switch (prompt_->type()) {

Powered by Google App Engine
This is Rietveld 408576698