Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: chrome/browser/extensions/blacklist_state_fetcher.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Two more Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/blacklist_state_fetcher.cc
diff --git a/chrome/browser/extensions/blacklist_state_fetcher.cc b/chrome/browser/extensions/blacklist_state_fetcher.cc
index c28afa0457cf08da80a0381d8f165cb9850877e8..bbb6523fd3c2875776c5ed98265f514af399b14b 100644
--- a/chrome/browser/extensions/blacklist_state_fetcher.cc
+++ b/chrome/browser/extensions/blacklist_state_fetcher.cc
@@ -40,7 +40,7 @@ class BlacklistRequestContextGetter : public net::URLRequestContextGetter {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
scoped_refptr<net::URLRequestContextGetter> context_getter =
- new BlacklistRequestContextGetter(parent_context_getter);
+ new BlacklistRequestContextGetter(parent_context_getter.get());
BrowserThread::PostTask(BrowserThread::UI,
FROM_HERE,
base::Bind(callback, context_getter));
@@ -99,8 +99,8 @@ void BlacklistStateFetcher::Request(const std::string& id,
if (request_already_sent)
return;
- if (url_request_context_getter_ ||
- !g_browser_process || !g_browser_process->safe_browsing_service()) {
+ if (url_request_context_getter_.get() || !g_browser_process ||
+ !g_browser_process->safe_browsing_service()) {
SendRequest(id);
} else {
scoped_refptr<net::URLRequestContextGetter> parent_request_context;
@@ -125,7 +125,7 @@ void BlacklistStateFetcher::SaveRequestContext(
const std::string& id,
scoped_refptr<net::URLRequestContextGetter> request_context_getter) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (!url_request_context_getter_)
+ if (!url_request_context_getter_.get())
url_request_context_getter_ = request_context_getter;
SendRequest(id);
}
@@ -145,7 +145,7 @@ void BlacklistStateFetcher::SendRequest(const std::string& id) {
this);
requests_[fetcher] = id;
fetcher->SetAutomaticallyRetryOn5xx(false); // Don't retry on error.
- fetcher->SetRequestContext(url_request_context_getter_);
+ fetcher->SetRequestContext(url_request_context_getter_.get());
fetcher->SetUploadData("application/octet-stream", request_str);
fetcher->Start();
}

Powered by Google App Engine
This is Rietveld 408576698