chrome/browser/extensions/sandboxed_unpacker.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_unpacker.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/process_manager_browsertest.cc ('k') | chrome/browser/extensions/settings_api_helpers.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/sandboxed_unpacker.cc

diff --git a/chrome/browser/extensions/sandboxed_unpacker.cc b/chrome/browser/extensions/sandboxed_unpacker.cc

index 56e51180a1d8f57a1a9bdf1a3d4356050f88f9c9..6b6c1c7e97ca3a9fbe58520112ac155e6d255ba8 100644

--- a/chrome/browser/extensions/sandboxed_unpacker.cc

+++ b/chrome/browser/extensions/sandboxed_unpacker.cc

@@ -696,8 +696,9 @@ bool SandboxedUnpacker::RewriteImageFiles(SkBitmap* install_icon) {

}

- const std::string& install_icon_path = IconsInfo::GetIcons(extension_).Get(

- extension_misc::EXTENSION_ICON_LARGE, ExtensionIconSet::MATCH_BIGGER);

+ const std::string& install_icon_path =

+ IconsInfo::GetIcons(extension_.get()).Get(

+ extension_misc::EXTENSION_ICON_LARGE, ExtensionIconSet::MATCH_BIGGER);

// Write our parsed images back to disk as well.

for (size_t i = 0; i < images.size(); ++i) {