chrome/browser/extensions/extension_error_controller_unittest.cc - Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_error_controller_unittest.cc

Issue 508513002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two more Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_error_controller.cc ('k') | chrome/browser/extensions/extension_gcm_app_handler_unittest.cc » ('j') | chrome/browser/extensions/webstore_standalone_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_error_controller_unittest.cc

diff --git a/chrome/browser/extensions/extension_error_controller_unittest.cc b/chrome/browser/extensions/extension_error_controller_unittest.cc

index ef8e6b153a8165452f3233b4d08ddd0ee1355449..2868a67e2afdb6845597d5da0e51e4612ca4923c 100644

--- a/chrome/browser/extensions/extension_error_controller_unittest.cc

+++ b/chrome/browser/extensions/extension_error_controller_unittest.cc

@@ -152,7 +152,7 @@ ExtensionPrefs* ExtensionErrorControllerUnitTest::GetPrefs() {

TEST_F(ExtensionErrorControllerUnitTest, ClosingAcknowledgesBlacklisted) {

// Add a blacklisted extension.

scoped_refptr<const Extension> extension = BuildExtension();

- ASSERT_TRUE(AddBlacklistedExtension(extension));

+ ASSERT_TRUE(AddBlacklistedExtension(extension.get()));

service_->Init();

@@ -181,7 +181,7 @@ TEST_F(ExtensionErrorControllerUnitTest, ClosingAcknowledgesBlacklisted) {

TEST_F(ExtensionErrorControllerUnitTest, AcceptingAcknowledgesBlacklisted) {

// Add a blacklisted extension.

scoped_refptr<const Extension> extension = BuildExtension();

- ASSERT_TRUE(AddBlacklistedExtension(extension));

+ ASSERT_TRUE(AddBlacklistedExtension(extension.get()));

service_->Init();

@@ -200,7 +200,7 @@ TEST_F(ExtensionErrorControllerUnitTest, AcceptingAcknowledgesBlacklisted) {

// already been acknowledged.

TEST_F(ExtensionErrorControllerUnitTest, DontWarnForAcknowledgedBlacklisted) {

scoped_refptr<const Extension> extension = BuildExtension();

- ASSERT_TRUE(AddBlacklistedExtension(extension));

+ ASSERT_TRUE(AddBlacklistedExtension(extension.get()));

GetPrefs()->AcknowledgeBlacklistedExtension(extension->id());