Issue 372103006: Stamp out CreateStringValue in chrome/

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed)

Created:
6 years, 5 months ago by Evan Stade

Modified:
6 years, 5 months ago

Reviewers:
Devlin, jar (doing other things), gab, David Tseng, Fady Samuel, dconnelly

CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, benjhayden+dwatch_chromium.org, dbeam+watch-options_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stamp out CreateStringValue in chrome/ Gets rid of the rest of CreateStringValue in non-test code in src/chrome/ BUG=160586 TBR=jar@chromium.org,dconnelly@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281939

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -63 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/info_private_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_dir_policy_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/policy_handlers.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/guest_view/web_view/javascript_dialog_helper.cc	View	1 chunk	+7 lines, -11 lines	0 comments	Download
M	chrome/browser/guest_view/web_view/web_view_guest.cc	View	6 chunks	+12 lines, -16 lines	0 comments	Download
M	chrome/browser/prefs/command_line_pref_store.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/speech/extension_api/tts_engine_extension_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/speech/extension_api/tts_extension_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/task_profiler/task_profiler_data_serializer.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/pack_extension_handler.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/version_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/app_window_custom_bindings.cc	View	1 chunk	+5 lines, -4 lines	1 comment	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

rdevlin.cronin: chrome/browser/chromeos/extensions/info_private_api.cc chrome/browser/extensions/policy_handlers.cc chrome/renderer/extensions/app_window_custom_bindings.cc jar: chrome/browser/task_profiler/task_profiler_data_serializer.cc gab: chrome/browser/prefs/command_line_pref_store.cc dtseng: chrome/browser/speech/extension_api/tts_engine_extension_api.cc chrome/browser/speech/extension_api/tts_extension_api.cc fsamuel: chrome/browser/guest_view/web_view/javascript_dialog_helper.cc chrome/browser/guest_view/web_view/web_view_guest.cc dconnelly: ...

6 years, 5 months ago (2014-07-08 01:22:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/372103006/1

6 years, 5 months ago (2014-07-08 21:40:35 UTC) #7

Message was sent while issue was closed.

Change committed as 281939

Expand Messages | Collapse Messages