chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc - Issue 372103006: Stamp out CreateStringValue in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc

diff --git a/chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc b/chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc

index 88d0dd2c624dce6d1d2ce776330fe585b0ad1691..2f408d295f23fdbd5a604f1d2b61972436ea8f44 100644

--- a/chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc

+++ b/chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc

@@ -78,10 +78,8 @@ void QuotaInternalsHandler::ReportStatistics(const Statistics& stats) {

void QuotaInternalsHandler::SendMessage(const std::string& message,

const base::Value& value) {

- scoped_ptr<base::Value> message_data(base::Value::CreateStringValue(message));

- web_ui()->CallJavascriptFunction("cr.quota.messageHandler",

- *message_data,

- value);

+ web_ui()->CallJavascriptFunction(

+ "cr.quota.messageHandler", base::StringValue(message), value);

}

void QuotaInternalsHandler::OnRequestInfo(const base::ListValue*) {