Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7186)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index caa685f9ed47d6b768d29e68ae708cff1a0ffbf8..42cf0906937bd15948009bfbd2f16d7f9049c331 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -361,7 +361,7 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
base::ListValue* warnings_list = new base::ListValue;
for (std::vector<std::string>::const_iterator iter = warnings.begin();
iter != warnings.end(); ++iter) {
- warnings_list->Append(base::Value::CreateStringValue(*iter));
+ warnings_list->Append(new base::StringValue(*iter));
}
extension_data->Set("warnings", warnings_list);
}
@@ -1163,7 +1163,7 @@ void ExtensionSettingsHandler::HandleShowPath(const base::ListValue* args) {
void ExtensionSettingsHandler::ShowAlert(const std::string& message) {
base::ListValue arguments;
- arguments.Append(base::Value::CreateStringValue(message));
+ arguments.Append(new base::StringValue(message));
web_ui()->CallJavascriptFunction("alert", arguments);
}

Powered by Google App Engine
This is Rietveld 408576698