chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc - Issue 372103006: Stamp out CreateStringValue in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/pack_extension_handler.cc ('k') | chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc » ('j') | chrome/renderer/extensions/app_window_custom_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

index fd8488e1bc345ebc9a7948cd20f571f1ca779f2f..ec86b3384931c660d2859246976df7c16f06974f 100644

--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

@@ -1334,8 +1334,9 @@ void InternetOptionsHandler::SetServerHostnameCallback(

NOTREACHED();

return;

}

- SetNetworkProperty(service_path, shill::kProviderHostProperty,

- base::Value::CreateStringValue(server_hostname));

+ SetNetworkProperty(service_path,

+ shill::kProviderHostProperty,

+ new base::StringValue(server_hostname));

}

void InternetOptionsHandler::SetPreferNetworkCallback(