Index: chrome/renderer/extensions/app_window_custom_bindings.cc |
diff --git a/chrome/renderer/extensions/app_window_custom_bindings.cc b/chrome/renderer/extensions/app_window_custom_bindings.cc |
index d9df7b469008646cad78a229bb12a05c3baaafc2..53cef266f1ca4b931b0da74a870befa3c43f169d 100644 |
--- a/chrome/renderer/extensions/app_window_custom_bindings.cc |
+++ b/chrome/renderer/extensions/app_window_custom_bindings.cc |
@@ -117,12 +117,13 @@ void AppWindowCustomBindings::GetWindowControlsHtmlTemplate( |
v8::Handle<v8::Value> result = v8::String::Empty(args.GetIsolate()); |
if (CommandLine::ForCurrentProcess()->HasSwitch( |
switches::kEnableAppWindowControls)) { |
- base::Value* value = base::Value::CreateStringValue( |
Evan Stade
2014/07/08 01:22:33
this was leaking
|
- ResourceBundle::GetSharedInstance().GetRawDataResource( |
- IDR_WINDOW_CONTROLS_TEMPLATE_HTML).as_string()); |
+ base::StringValue value( |
+ ResourceBundle::GetSharedInstance() |
+ .GetRawDataResource(IDR_WINDOW_CONTROLS_TEMPLATE_HTML) |
+ .as_string()); |
scoped_ptr<content::V8ValueConverter> converter( |
content::V8ValueConverter::create()); |
- result = converter->ToV8Value(value, context()->v8_context()); |
+ result = converter->ToV8Value(&value, context()->v8_context()); |
} |
args.GetReturnValue().Set(result); |
} |