chrome/browser/chrome_content_browser_client.cc - Issue 372103006: Stamp out CreateStringValue in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 618b9224253be07312707a4b7d3ba425b96516b5..70da3b2675d47c98706b272c9ab55c7eb34e1161 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -2415,8 +2415,8 @@ void ChromeContentBrowserClient::UpdateInspectorSetting(

Profile::FromBrowserContext(browser_context)->GetPrefs(),

prefs::kWebKitInspectorSettings);

base::DictionaryValue* inspector_settings = update.Get();

- inspector_settings->SetWithoutPathExpansion(

- key, base::Value::CreateStringValue(value));

+ inspector_settings->SetWithoutPathExpansion(key,

+ new base::StringValue(value));

}

void ChromeContentBrowserClient::BrowserURLHandlerCreated(