chrome/browser/speech/extension_api/tts_engine_extension_api.cc - Issue 372103006: Stamp out CreateStringValue in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

index e9951dfd4709a927daedf7195a02412a7d039748..4fb52de475d0aeeb2578ef99394fbcbc95e72d77 100644

--- a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

@@ -134,7 +134,7 @@ void ExtensionTtsEngineSpeak(Utterance* utterance, const VoiceData& voice) {

bool sends_end_event = voice.events.find(TTS_EVENT_END) != voice.events.end();

scoped_ptr<base::ListValue> args(new base::ListValue());

- args->Set(0, base::Value::CreateStringValue(utterance->text()));

+ args->Set(0, new base::StringValue(utterance->text()));

// Pass through most options to the speech engine, but remove some

// that are handled internally.