Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
diff --git a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc b/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
index 4209c3bdcce2982a92f1ac166e15dec9bfc2b1b9..a52219576c1ff834aa9d4e5aef33ef3f3733c71c 100644
--- a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
+++ b/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
@@ -49,17 +49,13 @@ void JavaScriptDialogHelper::RunJavaScriptDialog(
base::DictionaryValue request_info;
request_info.Set(
webview::kDefaultPromptText,
- base::Value::CreateStringValue(base::UTF16ToUTF8(default_prompt_text)));
- request_info.Set(
- webview::kMessageText,
- base::Value::CreateStringValue(base::UTF16ToUTF8(message_text)));
- request_info.Set(
- webview::kMessageType,
- base::Value::CreateStringValue(
- JavaScriptMessageTypeToString(javascript_message_type)));
- request_info.Set(
- guestview::kUrl,
- base::Value::CreateStringValue(origin_url.spec()));
+ new base::StringValue(base::UTF16ToUTF8(default_prompt_text)));
+ request_info.Set(webview::kMessageText,
+ new base::StringValue(base::UTF16ToUTF8(message_text)));
+ request_info.Set(webview::kMessageType,
+ new base::StringValue(
+ JavaScriptMessageTypeToString(javascript_message_type)));
+ request_info.Set(guestview::kUrl, new base::StringValue(origin_url.spec()));
webview_guest_->RequestPermission(
WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG,
request_info,

Powered by Google App Engine
This is Rietveld 408576698