Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6686)

Unified Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/pack_extension_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
index e7de840d7be2ffbd8b91d324863cd7b8e928ea06..d69068da9fb4f833a67ac572d3861c146be2745e 100644
--- a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
+++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
@@ -68,9 +68,8 @@ void PackExtensionHandler::RegisterMessages() {
void PackExtensionHandler::OnPackSuccess(const base::FilePath& crx_file,
const base::FilePath& pem_file) {
base::ListValue arguments;
- arguments.Append(base::Value::CreateStringValue(
- base::UTF16ToUTF8(PackExtensionJob::StandardSuccessMessage(
- crx_file, pem_file))));
+ arguments.Append(new base::StringValue(base::UTF16ToUTF8(
+ PackExtensionJob::StandardSuccessMessage(crx_file, pem_file))));
web_ui()->CallJavascriptFunction(
"extensions.PackExtensionOverlay.showSuccessMessage", arguments);
}
@@ -94,7 +93,7 @@ void PackExtensionHandler::OnPackFailure(const std::string& error,
void PackExtensionHandler::FileSelected(const base::FilePath& path, int index,
void* params) {
base::ListValue results;
- results.Append(base::Value::CreateStringValue(path.value()));
+ results.Append(new base::StringValue(path.value()));
web_ui()->CallJavascriptFunction("window.handleFilePathSelected", results);
}
@@ -200,7 +199,7 @@ void PackExtensionHandler::HandleSelectFilePathMessage(
void PackExtensionHandler::ShowAlert(const std::string& message) {
base::ListValue arguments;
- arguments.Append(base::Value::CreateStringValue(message));
+ arguments.Append(new base::StringValue(message));
web_ui()->CallJavascriptFunction(
"extensions.PackExtensionOverlay.showError", arguments);
}

Powered by Google App Engine
This is Rietveld 408576698