chrome/browser/ui/webui/version_handler.cc - Issue 372103006: Stamp out CreateStringValue in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/version_handler.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/version_handler.cc

diff --git a/chrome/browser/ui/webui/version_handler.cc b/chrome/browser/ui/webui/version_handler.cc

index 5e8672d7c1f3853f516a426877773dcceee99722..28947010821907827e643ec7e6729a6df81bb786 100644

--- a/chrome/browser/ui/webui/version_handler.cc

+++ b/chrome/browser/ui/webui/version_handler.cc

@@ -107,7 +107,7 @@ void VersionHandler::HandleRequestVersionInfo(const base::ListValue* args) {

base::ListValue variations_list;

for (std::vector<std::string>::const_iterator it = variations.begin();

it != variations.end(); ++it) {

- variations_list.Append(base::Value::CreateStringValue(*it));

+ variations_list.Append(new base::StringValue(*it));

}

// In release mode, this will return an empty list to clear the section.