chrome/browser/chromeos/extensions/info_private_api.cc - Issue 372103006: Stamp out CreateStringValue in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/info_private_api.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/info_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/info_private_api.cc b/chrome/browser/chromeos/extensions/info_private_api.cc

index 993683bf21781e56e23ecdd699e873b2ead392e9..60eed0da94280b354ff54d28f37cd3d545757b3c 100644

--- a/chrome/browser/chromeos/extensions/info_private_api.cc

+++ b/chrome/browser/chromeos/extensions/info_private_api.cc

@@ -184,7 +184,7 @@ base::Value* ChromeosInfoPrivateGetFunction::GetValue(

return base::Value::CreateBooleanValue(

chromeos::UserManager::Get()->IsCurrentUserOwner());

} else if (property_name == kPropertyClientId) {

- return base::Value::CreateStringValue(GetClientId());

+ return new base::StringValue(GetClientId());

} else if (property_name == kPropertyTimezone) {

return chromeos::CrosSettings::Get()->GetPref(

chromeos::kSystemTimezone)->DeepCopy();