Stamp out CreateStringValue in chrome/

chrome/renderer/extensions/app_window_custom_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/app_window_custom_bindings.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 99 matching lines @@
   args.GetReturnValue().Set(window);
 }
 
 void AppWindowCustomBindings::GetWindowControlsHtmlTemplate(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   CHECK_EQ(args.Length(), 0);
 
   v8::Handle<v8::Value> result = v8::String::Empty(args.GetIsolate());
   if (CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableAppWindowControls)) {
-    base::Value* value = base::Value::CreateStringValue(

[Evan Stade, 2014/07/08 01:22:33]

this was leaking

-        ResourceBundle::GetSharedInstance().GetRawDataResource(
-            IDR_WINDOW_CONTROLS_TEMPLATE_HTML).as_string());
+    base::StringValue value(
+        ResourceBundle::GetSharedInstance()
+            .GetRawDataResource(IDR_WINDOW_CONTROLS_TEMPLATE_HTML)
+            .as_string());
     scoped_ptr<content::V8ValueConverter> converter(
         content::V8ValueConverter::create());
-    result = converter->ToV8Value(value, context()->v8_context());
+    result = converter->ToV8Value(&value, context()->v8_context());
   }
   args.GetReturnValue().Set(result);
 }
 
 }  // namespace extensions