Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -117 lines) Patch
M pkg/compiler/lib/src/elements/jumps.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_usage.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +33 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 3 chunks +50 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/types.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 11 chunks +20 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 17 chunks +24 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 4 chunks +53 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/loop_handler.dart View 10 chunks +24 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-22 11:55:35 UTC) #2
Johnni Winther
PTAL
3 years, 6 months ago (2017-06-23 12:25:34 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2954463002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart File pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart (right): https://codereview.chromium.org/2954463002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart#newcode319 pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:319: // TODO(johnniwinther): Support do statement as jump target. ...
3 years, 6 months ago (2017-06-23 19:25:59 UTC) #4
Johnni Winther
https://codereview.chromium.org/2954463002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart File pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart (right): https://codereview.chromium.org/2954463002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart#newcode319 pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:319: // TODO(johnniwinther): Support do statement as jump target. On ...
3 years, 5 months ago (2017-06-26 07:57:36 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-06-26 08:35:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f7f4d6133b1a79307cc73db4d76c83cd58be2ff4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698