Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index d85656a48d9f0cdd400f358a4c93ed90940140ac..bf0cf5b1677dc2fc3fc8516f891c13a7b076c698 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -23,6 +23,7 @@ import '../elements/modelx.dart'
ErroneousElementX,
FunctionElementX,
JumpTargetX,
+ LabelDefinitionX,
LocalFunctionElementX,
LocalParameterElementX,
ParameterElementX,
@@ -4253,7 +4254,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
}
ResolutionResult visitBreakStatement(BreakStatement node) {
- JumpTarget target;
+ JumpTargetX target;
if (node.target == null) {
target = statementScope.currentBreakTarget();
if (target == null) {
@@ -4263,7 +4264,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
target.isBreakTarget = true;
} else {
String labelName = node.target.source;
- LabelDefinition label = statementScope.lookupLabel(labelName);
+ LabelDefinitionX label = statementScope.lookupLabel(labelName);
if (label == null) {
reporter.reportErrorMessage(
node.target, MessageKind.UNBOUND_LABEL, {'labelName': labelName});
@@ -4282,7 +4283,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
}
ResolutionResult visitContinueStatement(ContinueStatement node) {
- JumpTarget target;
+ JumpTargetX target;
if (node.target == null) {
target = statementScope.currentContinueTarget();
if (target == null) {
@@ -4292,7 +4293,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
target.isContinueTarget = true;
} else {
String labelName = node.target.source;
- LabelDefinition label = statementScope.lookupLabel(labelName);
+ LabelDefinitionX label = statementScope.lookupLabel(labelName);
if (label == null) {
reporter.reportErrorMessage(
node.target, MessageKind.UNBOUND_LABEL, {'labelName': labelName});
« no previous file with comments | « pkg/compiler/lib/src/kernel/types.dart ('k') | pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698